Skip to content

MQE-2138: Annotation static check incorrectly flags some extends test… #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2020
Merged

MQE-2138: Annotation static check incorrectly flags some extends test… #713

merged 2 commits into from
May 22, 2020
+10 −4

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented May 21, 2020

…s for missing issueIds

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented May 21, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.894% when pulling 283d63b on MQE-2138 into e2780f0 on 3.0.0-RC3.

jilu1
jilu1 previously approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soumyau soumyau changed the base branch from develop to 3.0.0-RC3 May 22, 2020 17:48
@soumyau soumyau merged commit 9505f04 into 3.0.0-RC3 May 22, 2020
@tomreece tomreece deleted the MQE-2138 branch July 27, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @jilu1